-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts/The Black Morass: Bug fixing #29957
base: 3.3.5
Are you sure you want to change the base?
Conversation
Did you write all the code in this PR or was it copied from somewhere? |
As for the post-event, I took the code from AzerothCore as a sample, but modified it to my liking. All the other changes I mentioned I wrote myself. |
TempSummon isnt defined. How are you even getting this to compile and work? |
My compiler is not as strict about checking for no includes. |
Did you mention anywhere in your PR description ? Did you include anywhere credits to the author of the original code ? |
No, I didn't. This is new to me. I'd be glad if you could help me get it right. Should I just point out that I relied on someone else's code and author? Should I attach a link to the code? |
Ideally, all code is written by you directly as a pull request submitter or in collaboration with someone who has agreed to submit the code to TC. If you are copying code from other projects, then we should mention the original authors and check that the license is compatible with TC one, which is often a hassle that we would rather avoid. |
Changes proposed:
Issues addressed:
Closes #27603
Tests performed:
build, tested in-game