Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working on guild #29953

Draft
wants to merge 5 commits into
base: wotlk_classic
Choose a base branch
from
Draft

Conversation

RioMcBoo
Copy link
Contributor

@RioMcBoo RioMcBoo commented May 2, 2024

Thanks Alistar, but i dk how to add him to RP

@RioMcBoo
Copy link
Contributor Author

RioMcBoo commented May 2, 2024

We need also tabard hotfixes for guild saving/loading to pass tabard validation image
static bool ValidateEmblemColors(uint32 style, uint32 color, uint32 borderStyle, uint32 borderColor, uint32 backgroundColor);

@RioMcBoo
Copy link
Contributor Author

RioMcBoo commented May 3, 2024

I'm a little taken aback. When I change access to bank tabs (several at once, and press "Accept" button), the client sends not one request, but each time a new request for each tab.

What causes the disconnect (I assume that the socket is disconnected due to packet spam, 3 packets in a row = disc)

When can i fix it particularly for this packets? or just test

And the client sends the packet every time I am changing rank permission flag, without pressing "Accept" button. And it spams packets to all members every time. WTF... Is it Blizz's antiprivates hack?

Maybe client has some opcode for turn on/off debug mode, or something?

- add broadcast message to players
- restore SRP principle of 'SendGuildRanksUpdate'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant