Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts/DK: Attempt to fix a Death Pact exploit #29920

Open
wants to merge 6 commits into
base: 3.3.5
Choose a base branch
from

Conversation

CraftedRO
Copy link
Contributor

@CraftedRO CraftedRO commented Apr 13, 2024

Changes proposed:

  • Attempt to fix an exploit where Death Pact does heal (it is usable) while the ghoul is under the effect of cyclone and doesn't sacrifice him.

Issues addressed:

Closes #28874

Tests performed:

Before:
2023-03-25.13-57-20.mp4
After:
2024-05-31.20-14-44.mp4

Does it build, tested in-game as you can see below:

Known issues and TODO list: (add/remove lines as needed)

  • [ maybe find smth that's not hardcoded ]

also fix some unexpected behaviour when you coud use spell with no ghoul summoned
@CraftedRO CraftedRO marked this pull request as draft May 26, 2024 18:54
@CraftedRO CraftedRO marked this pull request as ready for review May 31, 2024 17:13
if (undeadPet->IsAlive() &&
undeadPet->GetOwnerGUID() == player->GetGUID() &&
undeadPet->GetCreatureType() == CREATURE_TYPE_UNDEAD &&
undeadPet->IsWithinDist(player, 100.0f, false))
{
if (undeadPet->HasAura(33786) || undeadPet->HasAura(65859))
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove brackets (single line if)

if (undeadPet->IsAlive() &&
undeadPet->GetOwnerGUID() == player->GetGUID() &&
undeadPet->GetCreatureType() == CREATURE_TYPE_UNDEAD &&
undeadPet->IsWithinDist(player, 100.0f, false))
{
if (undeadPet->HasAura(33786) || undeadPet->HasAura(65859))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't check by spell id, use IsImmunedToSpell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants