Scripts/Outland: Added Shartuul's Transporter event

[14shagov]

Changes proposed:

• Added Shartuul's Transporter event

Issues addressed:

Closes #18655

Tests performed:

Builded and tested in game

Known issues and TODO list:

• I can't find the portal from which Shartuul exits.
• Spell 40675 is not working.
• Before Eye Stalk spawns, Shartuul summons a big meteor that hits the crystal, can't find this spell.
• Spell 41550 doesn't work right (directs the beam under itself, when it should be on the enemy)
• Before Eye Stalk appears, small meteorites are summoned. I can't implement it.
• Eye of Shartuul, when using Disruption Ray, causes Stun Fields, which are affected by the corresponding animation, I can’t find this animation.
• Spell 40493 is not working.
• When replacing a demon, the action bar of skills does not change; you need to click on the green arrow, which changes the bars.
• Sometimes, for some reason, when trash mobs appear, two green lightning bolts are thrown, there should be one
• I don’t know how to implement the change of abilities for Shivan Assassin when changing aspect
• When the bosses Doom Punisher, Shivan Assassin and Shartuul appear, they are in some kind of shadow. I can't find a spell that can do this.
• Not sure about the flag_extra changes. But if you don't remove flag 128, the creatures won't aggro. Yes, DB has similar creatures that are already transformed and don't have unnecessary flag_extra, but they are completely different in characteristics.
• Madness Rift should only cast in newly created Eye stalk.
• Charm - North 2-3 (40382,40523) - when used, cast Character Invis and Immune (40357), which makes all creatures in the area invisible, and Possess has no effect on Demon.

[14shagov]

Issues:

• I can't find the portal from which Shartuul exits.
• Spell 40675 is not working.
• Before Eye Stalk spawns, Shartuul summons a meteor that hits the crystal, can't find this spell.
• Spell 41550 doesn't work right (directs the beam under itself, when it should be on the enemy)
• Before Eye Stalk appears, small meteorites are summoned. I can't find this spell
• Eye of Shartuul, when using Disruption Ray, causes Stun Fields, which are affected by the corresponding animation, I can’t find this animation.
• Spell 40493 is not working.
• When replacing a demon, the action bar of skills does not change; you need to click on the green arrow, which changes the bars.
• Sometimes, for some reason, when trash mobs appear, two green lightning bolts are thrown, there should be one

[Faq]

add that under: Known issues and TODO list:

[lineagedr]

Pog

This might help you:

Spell: 40675 - Build Portable Fel Cannon
https://github.com/cmangos/mangos-wotlk/blob/6202f3045074980305a950d71e57058cef834427/src/game/AI/ScriptDevAI/scripts/outland/shartuul_transporter.cpp#L863

Spell: 40493 - Super Jump
https://github.com/cmangos/mangos-wotlk/blob/6202f3045074980305a950d71e57058cef834427/src/game/AI/ScriptDevAI/scripts/outland/shartuul_transporter.cpp#L637

[heyitsbench]

I do have sniffs of a few attempts at this event on Wrath Classic if it'd be any help to you. I can send them through Discord if you have it: @heyitsbench.

[14shagov]

This commit fixes issues with spells 40675 and 40493. I misspelled it.

[14shagov]

• It turns out that ability 40493 (Super Jump) still doesn't work. If you use it under Doom Punisher control, the ability can't select a target.
• A new issue occurred when I replaced Charm (530) with Charm - North 2-3 (40382, 40523) - when used, cast Character Invis and Immune (40357), which makes all creatures in the area invisible, and Possess has no effect on Demon.
• Another new issue, Madness Rift must only cast in newly created Eye stalk.

[14shagov]

I'm wondering if I should replace all npc and boss classes with structs? And use RegisterCreatureAI instead of new npc_blabla. As far as I understand, the new standard does exactly that.