Fix output datatype for some filters. #4988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiterLuc
changed the title
Assertion s % sizeof(T) == 0' failed`
shaunrd0
approved these changes
May 29, 2024
KiterLuc
added a commit
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.shortcut.com/tiledb-inc/story/47328
The addition of
Filter::output_datatypeto validate filter pipelines prevented some invalid pipelines from being constructed; but it depends on the correctness of eachoutput_datatypeimplementation to ensure that a filter can run correctly over the output of a previous filter.For the Rust bindings we have built randomized test strategies which assemble pipelines over combinations of filters which are unlikely to have appeared in the wild. This has exposed some missing or incorrect
output_datatypeimplementations which allow filters which depend on certain input properties to appear in pipelines erroneously.This pull request demonstrates some such cases in unit tests using the XOR and Delta compression filters, which depend on a particular bit width of their input, and fixes the
output_datatypeimplementations of filters which do not preserve the datatype between input and output.TYPE: BUG
DESC: Fix output datatype for some filters.