Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove StorageManager::compute_tp(). #4985

Merged
merged 1 commit into from
May 22, 2024
Merged

Remove StorageManager::compute_tp(). #4985

merged 1 commit into from
May 22, 2024

Conversation

bekadavis9
Copy link
Contributor

@bekadavis9 bekadavis9 commented May 16, 2024 •
edited by KiterLuc

Remove StorageManager::compute_tp(). This also removes a lot of StorageManager variables.

[sc-47579]

TYPE: NO_HISTORY
DESC: Remove StorageManager::compute_tp().

eric-hughes-tiledb
eric-hughes-tiledb approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@eric-hughes-tiledb eric-hughes-tiledb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR comment should mention that this is also removing some now-gratuitous occurences of local variables of type StorageManager.

LGTM otherwise

@KiterLuc KiterLuc merged commit ebaa63a into dev May 22, 2024
61 checks passed
@KiterLuc KiterLuc deleted the rd/sm_removals-compute_tp branch May 22, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-hughes-tiledb eric-hughes-tiledb eric-hughes-tiledb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bekadavis9 @eric-hughes-tiledb @KiterLuc