Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate APIs out of StorageManager: is_array and is_group. #4980

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

bekadavis9
Copy link
Contributor

@bekadavis9 bekadavis9 commented May 15, 2024

Create a new directory, tiledb/sm/object to house is_array and is_group, migrated from StorageManager.


[sc-46734]
[sc-46735]
[sc-47013]


TYPE: NO_HISTORY
DESC: Migrate APIs out of StorageManager: is_array and is_group.

Copy link
Contributor

@eric-hughes-tiledb eric-hughes-tiledb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the functions over looks fine, barring a small style point. But we really don't need a class Object at this time.

tiledb/sm/object/object.h Outdated Show resolved Hide resolved
tiledb/sm/object/object.cc Outdated Show resolved Hide resolved
tiledb/sm/object/object.cc Outdated Show resolved Hide resolved
tiledb/sm/object/object.cc Outdated Show resolved Hide resolved
@bekadavis9 bekadavis9 force-pushed the rd/object_dir branch 2 times, most recently from c9d3448 to 74b888e Compare May 16, 2024 20:48
Copy link
Contributor

@eric-hughes-tiledb eric-hughes-tiledb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KiterLuc KiterLuc merged commit 1b4e5c2 into dev May 22, 2024
61 checks passed
@KiterLuc KiterLuc deleted the rd/object_dir branch May 22, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants