-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated APIs from tests, part 4. #4957
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removed deprecated APIs from tests. It is the final PR to remove all deprecations. [sc-46307] --- TYPE: NO_HISTORY DESC: Remove deprecated APIs from tests, part 4.
KiterLuc
force-pushed
the
lr/tiledb-unit-remove-deprecations-4/ch46307
branch
2 times, most recently
from
May 10, 2024 09:58
5b25ce7
to
8c72715
Compare
KiterLuc
force-pushed
the
lr/tiledb-unit-remove-deprecations-4/ch46307
branch
3 times, most recently
from
May 10, 2024 11:34
56c7abf
to
a08779d
Compare
KiterLuc
force-pushed
the
lr/tiledb-unit-remove-deprecations-4/ch46307
branch
from
May 10, 2024 12:01
a08779d
to
104e7d5
Compare
KiterLuc
force-pushed
the
lr/tiledb-unit-remove-deprecations-4/ch46307
branch
from
May 21, 2024 05:51
59c350c
to
e095874
Compare
ypatia
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one question though
KiterLuc
added a commit
that referenced
this pull request
May 21, 2024
The change in #4957 caused us to create a full consolidation workspace on some deletes tests which in debug mode creates a few GB of memory to be initialized. This takes multiple seconds. --- TYPE: NO_HISTORY DESC: Fix the deletes test taking too long.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removed deprecated APIs from tests. It is the final PR to remove all deprecations.
[sc-46307]
TYPE: NO_HISTORY
DESC: Remove deprecated APIs from tests, part 4.