Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated APIs from tests, part 4. #4957

Merged
merged 5 commits into from
May 21, 2024

Conversation

KiterLuc
Copy link
Contributor

@KiterLuc KiterLuc commented May 9, 2024

This removed deprecated APIs from tests. It is the final PR to remove all deprecations.

[sc-46307]


TYPE: NO_HISTORY
DESC: Remove deprecated APIs from tests, part 4.

This removed deprecated APIs from tests. It is the final PR to remove all deprecations.

[sc-46307]

---
TYPE: NO_HISTORY
DESC: Remove deprecated APIs from tests, part 4.
@KiterLuc KiterLuc requested a review from ypatia May 9, 2024 10:46
@KiterLuc KiterLuc force-pushed the lr/tiledb-unit-remove-deprecations-4/ch46307 branch 2 times, most recently from 5b25ce7 to 8c72715 Compare May 10, 2024 09:58
@KiterLuc KiterLuc force-pushed the lr/tiledb-unit-remove-deprecations-4/ch46307 branch 3 times, most recently from 56c7abf to a08779d Compare May 10, 2024 11:34
@KiterLuc KiterLuc force-pushed the lr/tiledb-unit-remove-deprecations-4/ch46307 branch from a08779d to 104e7d5 Compare May 10, 2024 12:01
@KiterLuc KiterLuc force-pushed the lr/tiledb-unit-remove-deprecations-4/ch46307 branch from 59c350c to e095874 Compare May 21, 2024 05:51
Copy link
Contributor

@ypatia ypatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question though

test/src/test-capi-consolidation-plan.cc Show resolved Hide resolved
test/src/test-cppapi-aggregates.cc Show resolved Hide resolved
test/src/test-cppapi-consolidation-plan.cc Show resolved Hide resolved
@KiterLuc KiterLuc merged commit 1289793 into dev May 21, 2024
60 checks passed
@KiterLuc KiterLuc deleted the lr/tiledb-unit-remove-deprecations-4/ch46307 branch May 21, 2024 09:52
KiterLuc added a commit that referenced this pull request May 21, 2024
The change in #4957 caused us to create a full consolidation workspace on some deletes tests which in debug mode creates a few GB of memory to be initialized. This takes multiple seconds.

---
TYPE: NO_HISTORY
DESC: Fix the deletes test taking too long.
KiterLuc added a commit that referenced this pull request May 21, 2024
The change in #4957 caused us to create a full consolidation workspace
on some deletes tests which in debug mode creates a few GB of memory to
be initialized. This takes multiple seconds.

[sc-47836]

---
TYPE: NO_HISTORY
DESC: Fix the deletes test taking too long.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants