Switch to using the standards-conforming preprocessor for C++ #4407
+11
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be rebased after #4405 merges to see if it alleviates anything. |
ihnorton
reviewed
Oct 10, 2023
KiterLuc
force-pushed
the
eh/msvc-conforming-preprocessor
branch
from
756e5ea
to
1693277
Compare
MSVC by default uses its traditional, but non-conforming, preprocessor. The occasion for the switch is the new `__VA_OPT__` preprocessor macro in C++20, which allows a standard way of handling commas with `__VA_ARGS__`.
eric-hughes-tiledb
force-pushed
the
eh/msvc-conforming-preprocessor
branch
from
1693277
to
2ed67d9
Compare
|
It looks as though this strict preprocessor option is not compatible with VS 2019; there's warning inside the compiler's include files that's being escalated to an error. I doubt it's worth developing a workaround. There's a different error in VS 2022. This is from our dependency Changing the description to match these observations. |
|
4eda19c fixes the clipp incompatibility, feel free to cherry-pick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC by default uses its traditional, but non-conforming, preprocessor. The occasion for the switch is the new
__VA_OPT__preprocessor macro in C++20, which allows a standard way of handling commas with__VA_ARGS__.REQUIRES: No longer running
windows-19in CI. It looks like there is incompatibility between the strict preprocessor and that version of the compiler libraries.TYPE: NO_HISTORY
DESC: Switch to using the standards-conforming preprocessor for C++