Initial skeleton for flow_graph
#4158
Draft
+5,746
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with decomposition into stages mediated by concepts, and (2) passage through the stages from a static graph specification to an executable graph. Adds new directives to `.clang-format` to account for concept. This requires an upgrade to version 16.
KiterLuc
reviewed
Aug 18, 2023
|
|
||
| * Specifying a node by means of its node body: `flow_graph/node.h` | ||
| * Specifying a flow graph: `flow_graph/graph.h` | ||
| * Creating and running a flow graph: `flow_graph/system.h` |
There was a problem hiding this comment.
What about general_factory.h?
| The header `flow_graph/graph.h` contains support classes and all the concepts | ||
| need to specify a graph, either statically or dynamically. | ||
|
|
||
| ### Flow graph execution objects |
There was a problem hiding this comment.
Something might need to be added here as well for general_factory.
| @@ -0,0 +1,41 @@ | |||
| /** | |||
| * @file flow_graph/node_body.h | |||
There was a problem hiding this comment.
Suggested change
| * @file flow_graph/node_body.h | |
| * @file flow_graph/graph.h |
| @@ -0,0 +1,25 @@ | |||
| # | |||
| # flow_graph/execution_platform/CMakeLists.txt | |||
There was a problem hiding this comment.
flow_graph/library/platform/CMakeLists.txt
| @@ -0,0 +1,48 @@ | |||
| /** | |||
| * @file flow_graph/library/basic/basic_execution_platform.h | |||
There was a problem hiding this comment.
Suggested change
| * @file flow_graph/library/basic/basic_execution_platform.h | |
| * @file tiledb/flow_graph/library/platform/minimal_execution_platform.h |
| } | ||
| } | ||
|
|
||
| //--------------------- |
|
|
||
| namespace tiledb::flow_graph { | ||
|
|
||
| //------------------------------------------------------- |
| template <class T> | ||
| concept empty_product_type = product_type<T> && (factor_sizeof<T>() == 0); | ||
|
|
||
| //---------------------------------- |
There was a problem hiding this comment.
What is the empty box for?
| constexpr bool is_equal_reference(const T& x, const U& y) { | ||
| if constexpr (!(std::is_same_v<std::remove_cv_t<T>, std::remove_cv_t<U>>)) { | ||
| return false; | ||
| } else { |
There was a problem hiding this comment.
This doesn't seem to be doing what the comment is saying?
| template <typename... U> | ||
| reference_tuple(const U&...) -> reference_tuple<const U&...>; | ||
|
|
||
| /* |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial skeleton for
flow_graph. Focus is on (1) overall structure with decomposition into stages mediated by concepts, and (2) passage through the stages from a static graph specification to an executable graph.Adds new directives to
.clang-formatto account for concept. This requires an upgrade to version 16.TYPE: NO_HISTORY
DESC: Initial skeleton for
flow_graph