[WIP] Moving unfiltered data to larger allocations. #4080
+1,409
−200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #26933: Refactor to do larger allocations for unfiltering. |
KiterLuc
changed the title
KiterLuc
force-pushed
the
lr/unfiltered-data-blocks/ch26933
branch
3 times, most recently
from
3f8343b
to
14f2781
Compare
KiterLuc
force-pushed
the
lr/unfiltered-data-blocks/ch26933
branch
3 times, most recently
from
04c535e
to
c44c635
Compare
This moves the unfiltered data buffer from the Tile class to a larger allocation and provide a way to get a pointer to the data. At the moment, the tile class still stores a pointer into the larger allocation but eventually all accesses will be changed to get the tile data from the UnfilteredData class. It also modifies the sparse global order reader to only load more tiles from a fragment once it is fully processed. --- TYPE: IMPROVEMENT DESC: Moving unfiltered data to larger allocations.
KiterLuc
force-pushed
the
lr/unfiltered-data-blocks/ch26933
branch
from
c44c635
to
c25bc91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the unfiltered data buffer from the Tile class to a larger allocation and provide a way to get a pointer to the data. At the moment, the tile class still stores a pointer into the larger allocation but eventually all accesses will be changed to get the tile data from the UnfilteredData class.
It also modifies the sparse global order reader to only load more tiles from a fragment once it is fully processed.
TYPE: IMPROVEMENT
DESC: Moving unfiltered data to larger allocations.