Refactor the thread pool and remove its dependency on statuses. #4063
+276
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
force-pushed
the
tp-unstatus
branch
4 times, most recently
from
0ab2b40
to
aabd08e
Compare
teo-tsirpanis
force-pushed
the
tp-unstatus
branch
from
aabd08e
to
6fbbc92
Compare
teo-tsirpanis
force-pushed
the
tp-unstatus
branch
from
d8ff17b
to
d6f2947
Compare
…ferred future. And add a test.
Non-MSVC compilers do not support explicit specializations inside a class.
We don't need to return results from thread pool work items.
`ThreadPool::pump` was always blocking to wait on a new task, but want that only in thread pool worker threads. Non-worker threads that are waiting on their task must not block.
Apparently it causes segfaults in Catch.
teo-tsirpanis
force-pushed
the
tp-unstatus
branch
from
d6f2947
to
fbbf3d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the thread pool to support working with futures of arbitrary return types, instead of only statuses. This is achieved by adding generic variants to existing methods, and changing the producer-consumer queue to store
std::function<void()>s instead ofstd::shared_ptr<std::packaged_task<Status()>>es. The existingStatusoverloads remain for compatibility.While not many things outside the thread pool are affected, this will make future "unstatusing" work easier.
TODO
genericvoidoverloads ofwait_all.parallel_sortas a proof of concept; it's trivial since it never returns a failing status.TYPE: IMPROVEMENT
DESC: Refactor the thread pool.