OpenIddict implementation, role section, override scope and role key #1431

Eits-Ian · 2021-02-07T18:16:24Z

"ScopeKey": "oi_scp" to enable OpenIddict

"RequiredRole": [ "User" ]

Fixes / New Feature #
???

Proposed Changes

Added role section
Variable to define an override for the scope or role descriptor

raman-m · 2023-07-11T13:30:22Z

Hi @Eits-Ian !
Thanks for your interest in Ocelot gateway!

Please do the following:

Merge PR 1
Rebase feature branch onto develop
Resolve all merge conflicts

raman-m · 2023-08-23T15:22:45Z

@Eits-Ian
I thought you needed a help to resolve the conflicts.
The feature branch has been rebased onto ThreeMammals:develop successfully!
Now we have 4 failed tests!
We cannot start code review till all tests have passed...

I see that develop branch in your fork is old.
Could you Sync fork please? So, the develop branch will be updated with all top commits!
Could you add me as collaborator to your forked repo please? I will update develop branch.

raman-m

4 failed tests!
Could you review & fix them please?

Eits-Ian · 2023-08-24T10:28:27Z

Sorry I did not get a chance to look at this till today, should be fixed, have added you as a collaborator, I hadn't looked at this for a couple of years. Need to add process policies, I am really busy at the moment so will not be able to get to this for a while.

Eits-Ian · 2023-08-24T11:12:13Z

The error is at ClaimsToDownstreamPathTests it is not authenticating, I need to take a look at what is happening but it will need to be later

raman-m · 2023-08-28T15:27:33Z

@Eits-Ian commented on Aug 24

Thanks for caring!
I am planning to help you in September by having of some pair programming...
Sorry, now I have a lot of things to do with this project...

raman-m · 2024-04-16T16:27:09Z

The branch has been rebased onto release/24.0 which has top commit 59b63ea !

Further development is required❕
Fixing failed tests is required❗

raman-m · 2024-04-16T16:33:17Z

@Eits-Ian Dear author,
Are you still with Ocelot?
And, what's your name? 😉

Will this PR close, is PR related to the following issues?

Multiple values for single key in RouteClaimsRequirement #746
Ocelot doesn't handle correctly RouteClaimsRequirement with a key as an Url #679
Alternate array syntax to resolve : issue in key names for RouteClaimsRequirement option in configuration #1308

Please answer ASAP❗

P.S.

OpenIddict implementation, role section, override scope and role key

What is OpenIddict? It should likely not be part of the PR title; instead, the title should include Ocelot's artifact name or, if necessary, the ASP.NET one.

Eits-Ian · 2024-04-18T15:29:35Z

Raman, I need to go back and look at the code to see what I did but from memory, you could specify the roles/scopes but not use an authorization policy and it worked with openiddict. I haven't got much time to do much with this at the moment, I will need to get back into it as I must update the api, that use this, but that will not be for a few months. Best, Ian.

raman-m · 2024-04-19T08:48:12Z

I haven't got much time to do much with this at the moment, I will need to get back into it as I must update the api, that use this, but that will not be for a few months

It should be a matter of weeks, not months!

Eits-Ian · 2024-04-19T11:13:18Z

Raman, With all due respect I have a 3-year clinic project just about to open which I am a part owner of the clinic, and this is my priority, I'm not coding all day long. Best, Ian.

raman-m · 2024-04-19T13:20:50Z

@Eits-Ian
I don't understand you!
Should we close the PR or will you develop it in coming future?

"ScopeKey": "oi_scp" to enable OpenIddict "RequiredRole": [ "User" ]

…lways have its default value null

Registered IRolesAuthorizer Fixed Test should_not_be_valid_if_specified_authentication_provider_isnt_registered()

Fixed test configuration_is_invalid_with_invalid_authentication_provider()

Eits-Ian · 2024-04-19T14:08:27Z

Raman, As I said I do need to do it, but I will not be able to get to it for a few months, I currently end up losing days weeks to the clinic, then I get back to some coding but that is only a few hours at a time. In a few months the clinic will be open, and I will get back to this, I wish I had more time now, but I work 7 day weeks and all hours so there is just no more to give. Best, Ian.

raman-m · 2024-04-19T14:27:18Z

🆗 Got it! You are super busy… In this case, let me decide what to do with this PR…

raman-m · 2024-04-19T14:45:29Z

src/Ocelot/Authorization/Middleware/AuthorizationMiddleware.cs

+            if (!IsOptionsHttpMethod(httpContext) && IsAuthenticatedRoute(downstreamRoute))
+            {


Why did you copy whole if-block above?

I strongly disapprove of any form of copying of blocks❗

raman-m · 2024-04-19T16:22:23Z

So, @Eits-Ian … The current implication is failing of 5 acceptance tests❗ See the build results!

raman-m assigned Eits-Ian Jul 11, 2023

raman-m added the conflicts Feature branch has merge conflicts label Jul 11, 2023

raman-m force-pushed the OpenIddict branch from a23ffc1 to b0905e5 Compare August 23, 2023 15:02

raman-m added feature A new feature proposal Proposal for a new functionality in Ocelot needs feedback Issue is waiting on feedback before acceptance and removed conflicts Feature branch has merge conflicts labels Aug 23, 2023

raman-m requested changes Aug 23, 2023

View reviewed changes

raman-m added the 2023 Annual 2023 release label Mar 5, 2024

raman-m added this to the Annual 2023 milestone Mar 5, 2024

raman-m changed the base branch from develop to release/24.0 March 5, 2024 10:04

raman-m force-pushed the OpenIddict branch from 6e768d0 to dcd2ed3 Compare April 7, 2024 11:51

raman-m force-pushed the OpenIddict branch from dcd2ed3 to d54890a Compare April 16, 2024 16:20

raman-m added waiting Waiting for answer to question or feedback from issue raiser and removed needs feedback Issue is waiting on feedback before acceptance labels Apr 16, 2024

raman-m mentioned this pull request Apr 16, 2024

#913 #1066 ScopesAuthorizer refactoring #1478

Open

Eits-Ian and others added 3 commits April 19, 2024 16:27

OpenIddict implementation, role section, override scope and role key

1b72c87

"ScopeKey": "oi_scp" to enable OpenIddict "RequiredRole": [ "User" ]

Fix warnings

af56dce

Fix CS0649: Field '_rolesAuthorizer' is never assigned to, and will a…

921a620

…lways have its default value null

raman-m and others added 5 commits April 19, 2024 16:27

Fix messages

9007635

Fixed errors

c2be093

Registered IRolesAuthorizer Fixed Test should_not_be_valid_if_specified_authentication_provider_isnt_registered()

Fixed test

f036449

Fixed test configuration_is_invalid_with_invalid_authentication_provider()

Refactor AuthenticationOptions

448c9f8

Fix compiling errors

1786901

raman-m force-pushed the OpenIddict branch from d54890a to 1786901 Compare April 19, 2024 13:32

raman-m reviewed Apr 19, 2024

View reviewed changes

raman-m added 2 commits April 19, 2024 18:01

Quick code review from @raman-m

e01a455

Fix unit tests

706fdc1

raman-m added the low Low priority label Apr 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OpenIddict implementation, role section, override scope and role key #1431

OpenIddict implementation, role section, override scope and role key #1431

Eits-Ian commented Feb 7, 2021 •

edited by raman-m

raman-m commented Jul 11, 2023

raman-m commented Aug 23, 2023

raman-m left a comment

Eits-Ian commented Aug 24, 2023

Eits-Ian commented Aug 24, 2023

raman-m commented Aug 28, 2023

raman-m commented Apr 16, 2024

raman-m commented Apr 16, 2024 •

edited

Eits-Ian commented Apr 18, 2024 via email •

edited by raman-m

raman-m commented Apr 19, 2024

Eits-Ian commented Apr 19, 2024 via email •

edited by raman-m

raman-m commented Apr 19, 2024

Eits-Ian commented Apr 19, 2024 via email •

edited by raman-m

raman-m commented Apr 19, 2024

raman-m Apr 19, 2024 •

edited

raman-m commented Apr 19, 2024

		if (!IsOptionsHttpMethod(httpContext) && IsAuthenticatedRoute(downstreamRoute))
		{

OpenIddict implementation, role section, override scope and role key #1431

Are you sure you want to change the base?

OpenIddict implementation, role section, override scope and role key #1431

Conversation

Eits-Ian commented Feb 7, 2021 • edited by raman-m

Proposed Changes

raman-m commented Jul 11, 2023

raman-m commented Aug 23, 2023

raman-m left a comment

Choose a reason for hiding this comment

Eits-Ian commented Aug 24, 2023

Eits-Ian commented Aug 24, 2023

raman-m commented Aug 28, 2023

raman-m commented Apr 16, 2024

raman-m commented Apr 16, 2024 • edited

P.S.

Eits-Ian commented Apr 18, 2024 via email • edited by raman-m

raman-m commented Apr 19, 2024

Eits-Ian commented Apr 19, 2024 via email • edited by raman-m

raman-m commented Apr 19, 2024

Eits-Ian commented Apr 19, 2024 via email • edited by raman-m

raman-m commented Apr 19, 2024

raman-m Apr 19, 2024 • edited

Choose a reason for hiding this comment

raman-m commented Apr 19, 2024

Eits-Ian commented Feb 7, 2021 •

edited by raman-m

raman-m commented Apr 16, 2024 •

edited

Eits-Ian commented Apr 18, 2024 via email •

edited by raman-m

Eits-Ian commented Apr 19, 2024 via email •

edited by raman-m

Eits-Ian commented Apr 19, 2024 via email •

edited by raman-m

raman-m Apr 19, 2024 •

edited