Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'multipart/form-data' support for file uploads #1372

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Add 'multipart/form-data' support for file uploads #1372

wants to merge 10 commits into from

Conversation

myall200
Copy link

@myall200 myall200 commented Nov 13, 2020 •
edited by raman-m

Fixes #714

Motivation

Introduce a support of file streaming (file uploads) via the gateway, without body content caching.
Current loading of entire body to a memory in Ocelot core is a source of errors, unstable responses because downstream services produce errors during long lasting operation of the request.

Proposed Changes

  • add multipart/form-data support for file uploads

Related to

@raman-m raman-m changed the base branch from master to develop July 15, 2023 14:14
@raman-m
Copy link
Member

raman-m commented Jul 15, 2023

Hi zenghao!
Thanks for your interest in Ocelot!

Why did you revert the changes by reverting commit?

Could you Sync fork please? There is no develop branch in the forked repo!

@raman-m
Copy link
Member

raman-m commented Aug 11, 2023

Related to:

@raman-m raman-m changed the title Add multipart/form-data Support Add 'multipart/form-data' support for file uploads Aug 11, 2023
@raman-m
Copy link
Member

raman-m commented Aug 11, 2023 •
edited

@myall200 Hi Zenghao!
Do you have any intention of contributing to this feature further?

I hope, if we will have a pair programming sessions together, we could deliver full functioning feature and the PR could close the list of open issues.

Happy Friday!
Have a nice sunny weekend in China! 😉

myall200 and others added 10 commits August 11, 2023 21:19
@myall200 @raman-m
add multipart/form-data support
13c734e 
add multipart/form-data support
@myall200 @raman-m
Revert "add multipart/form-data support"
bd0e3ab 
This reverts commit 72cb5e6.
@raman-m
Add Request.Form copying
ae34f1d
@raman-m
Use expression body for method
151a1d9
@raman-m
CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve …
aa9936e 
…readability. Replace with `string.Contains`
@raman-m
CS0026: Keyword 'this' is not valid in a static property, static meth…
f9a7d83 
…od, or static field initializer
@raman-m
SA1513: Closing brace should be followed by blank line. Insert blank …
5728312 
…line after brace
@raman-m
SA1508: A closing brace should not be preceded by a blank line. Remov…
d35e8c4 
…e blank lines preceding this brace
@raman-m
IDE0059: Unnecessary assignment of a value to 'content'. Remove redun…
3fe038d 
…dant assignment
@raman-m
IDE0063: 'using' statement can be simplified
f5e6a89
@raman-m
Copy link
Member

raman-m commented Aug 11, 2023 •
edited

The feature branch (master) has been rebased onto ThreeMammals:develop!

I don't see develop branch in your fork! Your fork is too old.

Could you Sync fork please? So, new develop branch will occur with all top commits!

Could you add me as collaborator to your forked repo please? I will create develop branch and make it default.

There are 2 failed tests in the build:

Fully qualified names:

Reason: [Incorrect Content-Type:]
I guess it won't be hard to fix these failed tests.

@raman-m raman-m added feature A new feature help wanted Not actively being worked on. If you plan to contribute, please drop a note. large effort Likely over a week of development effort medium effort Likely a few days of development effort needs feedback Issue is waiting on feedback before acceptance labels Aug 11, 2023
raman-m
raman-m requested changes Aug 11, 2023
View reviewed changes
Copy link
Member

@raman-m raman-m left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\color{red}{There\ are\ 2\ failed\ tests\ in\ the\ build!}$

$\color{red}{There\ are\ 2\ failed\ tests\ in\ the\ build!}$

Build: 1422

@raman-m raman-m mentioned this pull request Dec 5, 2023
Closed
@raman-m raman-m mentioned this pull request Jan 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raman-m raman-m raman-m requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@myall200 myall200

Labels
feature A new feature help wanted Not actively being worked on. If you plan to contribute, please drop a note. large effort Likely over a week of development effort medium effort Likely a few days of development effort needs feedback Issue is waiting on feedback before acceptance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multipart/form-data is not rerouted (error 404)
2 participants
@myall200 @raman-m