Missing scheme on downstream request #1274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Ruben! What issue is this PR related to? If Not related, |
raman-m
requested changes
Jul 19, 2023
There was a problem hiding this comment.
What do I see now...
You've added this predicate suffix: && s.HostAndPort.Scheme == lease.HostAndPort.Scheme
This suffix will help to recognize, filter the service from the list which contains multiple services with the same host and port, but they differ by scheme, right?
I might approve this. And current acceptance/unit tests are not broken...
But...
Could you add a few unit tests in LeastConnectionTests please? They should cover new added predicate suffix.
Also adding new acceptance tests for LeastConnection are welcome!
raman-m
added
question
On the LeastConnection balancer the downstream host scheme property is ignored and not return when Lease is called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual Behavior
On the LeastConnection balancer the downstream host scheme property is ignored and not return when Lease is called.
Fixes
???
Proposed Changes
HostAndPort.Schemeproperty into account