Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipart/form-data is not rerouted (error 404) #714

Open
EdwinVanRooij opened this issue Dec 11, 2018 · 1 comment · May be fixed by #1372
Open

Multipart/form-data is not rerouted (error 404) #714

EdwinVanRooij opened this issue Dec 11, 2018 · 1 comment · May be fixed by #1372
Labels
bug Identified as a potential bug help wanted Not actively being worked on. If you plan to contribute, please drop a note. needs validation Issue has not been replicated or verified yet

Comments

@EdwinVanRooij
Copy link
Contributor

EdwinVanRooij commented Dec 11, 2018

Expected Behavior

A multipart/form-data http POST request is redirected to the desired endpoint.

Actual Behavior

An error 404 - not found http response is given.

Description

I won't include steps to reproduce the problem etc, because I'm pretty sure the feature is just not implemented (yet - or intentional).

Question

Is rerouting a file upload using multipart/form-data desired functionality, or is in an intentionally left out thing?
I could imagine you'd not want to reroute such a file upload because of the overhead - why not just upload the file directly to the API?
However, if the overhead is as little as the normal http requests are (about 1 ms), then I'd think it would be preferable to support multipart/form-data http post requests in reroutes.

Edit:
The reason I'm certain that I haven't just incorrectly configured the reroute, is as follows:
When I send the request with no file in the parameter, the reroute works and gets into my other API.
When I send the request with a file in the parameter, error 404 occurs, thrown by Ocelot presumably.

@philproctor philproctor self-assigned this Jan 2, 2019
@philproctor philproctor added question Initially seen a question could become a new feature or bug or closed ;) needs validation Issue has not been replicated or verified yet bug Identified as a potential bug help wanted Not actively being worked on. If you plan to contribute, please drop a note. and removed question Initially seen a question could become a new feature or bug or closed ;) labels Jan 9, 2019
@philproctor philproctor removed their assignment Jan 9, 2019
@raman-m raman-m linked a pull request Aug 11, 2023 that will close this issue
@raman-m
Copy link
Member

raman-m commented Jan 7, 2024

@EdwinVanRooij
You can contribute.
I guess this issue can be fixed by PR #1372 . But it should be developed more...

@raman-m raman-m changed the title [Question]: Multipart/form-data is not rerouted (error 404). Plans to support? Multipart/form-data is not rerouted (error 404) Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identified as a potential bug help wanted Not actively being worked on. If you plan to contribute, please drop a note. needs validation Issue has not been replicated or verified yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants