819 - refactor use_files.R before adding replace arg #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HI, i prefer |
ilyaZar
force-pushed
the
819-use_external_with_replace
branch
from
fc73159
to
558de24
Compare
UpdateUpdate this PR-branch to be up-to-date with current
Notes:@ColinFay this PR is a bit of a mess unfortunately as it had to be adjusted to updates made in 7ba820b But since there is a 100% test coverage for the file Let me know if you request any other changes ! |
Aim: - reduce duplication - make long term maintanence easier - ease the later addition of 'replace'-argument as this needs then to be done only in one place How: - encapsulate internals of use_external_js_file to separate funcs - re-use separate funcs to reduce duplication in use_external_css_file Possible To-Dos: - re-use separate funcs to reduce duplication in use_external_html_template - re-use separate funcs to reduce duplication in use_external_file
- has same structure as use_external_{js,css}_file()
- add check_url_valid
ilyaZar
force-pushed
the
819-use_external_with_replace
branch
2 times, most recently
from
029ecf3
to
fc86051
Compare
- no dance for use_external_file - no url check for use_external - no new-file creation for use_external Otherwise, same internal structure as other use_external_XXX funcs
default value can be NULL and NULL can be passed as argument
-> check for both cases
-> use basename of the URL correctly in this case
`file_path_sans_ext(name)` gets rid of the extension this must be handled inside tests correctly
ilyaZar
force-pushed
the
819-use_external_with_replace
branch
from
fc86051
to
54d1668
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #819 , there is the possibility to refactor the internals of
use_external_XXXtype functions inuse_files.Rprior to the addition of a new replace arg.This may or may not be useful; I think it could be, hence the draft PR with some benefits being to reduce duplication
It's easier to add the 'replace'-argument in only one place then (see last commit to this PR).
Essentially all
use_external_xxxfuncs inuse_files.Rdo the same, so this PR tries to encapsulate identical behaviour into smaller maintainable pieces.Of course this proposal comes along with quite some work and probably there should be some tests added as well... happy do get on this though!