Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting: Update broken link in knowledge check #27991

Closed
wants to merge 1 commit into from

Conversation

Mafzii
Copy link

@Mafzii Mafzii commented May 17, 2024

Because

Clicking "Which problems can linting prevent?" would open page that does not exist anymore, causing a 404. Added a different link that provides answers about the link description and is from a trusted source.

This PR

Issue

Contributing doc said no issue needs to be made for a small fix

Additional Information

If there is any better link to include instead of the one added comment it below

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: JavaScript Involves the JavaScript course label May 17, 2024
@CouchofTomato CouchofTomato requested review from a team and bycdiaz and removed request for a team May 17, 2024 13:29
@Mafzii
Copy link
Author

Mafzii commented May 21, 2024

@MaoShizhong it seems like someone else's PR was accepted even though it was made after mine. Maybe add a label for PRs that are not attached to an issue so that its easier to see duplicates of these small fixes? Also should I close this PR now that its outdated?

@MaoShizhong
Copy link
Contributor

MaoShizhong commented May 21, 2024

@MaoShizhong it seems like someone else's PR was accepted even though it was made after mine. Maybe add a label for PRs that are not attached to an issue so that its easier to see duplicates of these small fixes? Also should I close this PR now that its outdated?

PRs that are linked to close issues do have a symbol on them in the PR list (so if it doesn't have it, it's not linked to close an open issue):
image

What happened here though was just 100% my own mistake. I check open issues and PRs for this before reviewing, but I just straight up completely missed this PR, which is why I approved the later one. So that's entirely on me and I apologise for this.

In this instance, we can close this PR because an appropriate change has already been made for the issue raised by this PR. Again, my apologies. We would typically catch duplicates when we check things.
I'm sure there will be more contribution opps available though, so do keep an eye out! And thank you for opening this PR as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: JavaScript Involves the JavaScript course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants