Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rock Paper Scissors: Fix ambiguous parameter #27989

Merged
merged 1 commit into from
May 17, 2024

Conversation

sukairaida
Copy link
Contributor

Because

The third instruction on the step 5 of the RPS project refers to a humanSelection parameter that hasn't been defined yet, this PR replaces it with humanChoice which is the given name to the parameter in the fuction defined before. This could prevent new learners from getting confused about it.

This PR

  • Replace humanSelection with humanChoice on the third instruction of the 5th step of the project.

Issue

Closes #27988

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label May 17, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@MaoShizhong MaoShizhong merged commit 79b0c8e into TheOdinProject:main May 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rock Paper Scissors: ambiguous instruction on step 5
2 participants