Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update testing db instructions lesson #27974

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

01zulfi
Copy link
Member

@01zulfi 01zulfi commented May 15, 2024

Because

#27928

This PR

replaces MongoDB instructions with how to setup test postgres db. Touch a bit on unit & integration test

admittedly the lesson is a bit undercooked (the whole testing section needs a overhaul). this PR just gets enough stuff done to push node revamp milestone 1 out the door

Issue

Closes #27928

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@01zulfi 01zulfi added the Project Node Revamp Issues/PRs related to the Node Revamp project label May 15, 2024
@github-actions github-actions bot added the Content: NodeJS Involves the NodeJS course label May 15, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

nodeJS/testing_express/testing_database_operations.md Outdated Show resolved Hide resolved
nodeJS/testing_express/testing_database_operations.md Outdated Show resolved Hide resolved
nodeJS/testing_express/testing_database_operations.md Outdated Show resolved Hide resolved
nodeJS/testing_express/testing_database_operations.md Outdated Show resolved Hide resolved
nodeJS/testing_express/testing_database_operations.md Outdated Show resolved Hide resolved
nodeJS/testing_express/testing_database_operations.md Outdated Show resolved Hide resolved
nodeJS/testing_express/testing_database_operations.md Outdated Show resolved Hide resolved
nodeJS/testing_express/testing_database_operations.md Outdated Show resolved Hide resolved
01zulfi and others added 8 commits May 18, 2024 18:30
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
@01zulfi 01zulfi requested a review from MaoShizhong May 18, 2024 13:34
@MaoShizhong
Copy link
Contributor

@01zulfi What do you think about assignments? Is there anything e.g. documentation that you think may be worth mentioning in a short assignment section?

@01zulfi 01zulfi added the Status: Do Not Merge This PR should not be merged until further notice label May 18, 2024
@01zulfi
Copy link
Member Author

01zulfi commented May 18, 2024

@MaoShizhong I have nothing in mind right now. We'll not be merging this PR until we ship. So, I might add an assignment item or two after working through the Prisma lessons and revising all of the other lessons.

@MaoShizhong
Copy link
Contributor

@MaoShizhong I have nothing in mind right now. We'll not be merging this PR until we ship. So, I might add an assignment item or two after working through the Prisma lessons and revising all of the other lessons.

That's fair. I think having a brief assignment section would benefit, on top of following the style guide of course. Not 100% sure what since I'm less familiar with the new content specifically, but I'll drop any suggestions if I come across them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: NodeJS Involves the NodeJS course Project Node Revamp Issues/PRs related to the Node Revamp project Status: Do Not Merge This PR should not be merged until further notice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Lesson: Testing Database Operations
2 participants