Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: path agnostic sql course #27965

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: path agnostic sql course #27965

wants to merge 2 commits into from

Conversation

01zulfi
Copy link
Member

@01zulfi 01zulfi commented May 12, 2024

Because

#27014

This PR

makes sql course path agnostic

Issue

Closes #27014

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Databases Involves the Databases course label May 12, 2024
@01zulfi 01zulfi added the Status: Do Not Merge This PR should not be merged until further notice label May 12, 2024
@01zulfi 01zulfi force-pushed the node-revamp/agnostic-sql branch 2 times, most recently from cd9177a to 628b27a Compare May 12, 2024 10:25
@01zulfi 01zulfi changed the title feat: path agonstic sql course feat: path agnostic sql course May 12, 2024
@01zulfi 01zulfi added the Project Node Revamp Issues/PRs related to the Node Revamp project label May 12, 2024
MaoShizhong
MaoShizhong requested changes May 12, 2024
View reviewed changes
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! While we're at it, mind fixing up some of the links that need to be more accurate/descriptive?
https://docs.google.com/spreadsheets/d/1rM9tjPIFZbKoMfd6OlLnjOhddBe2bivllY8_Bg5aGqY/edit?usp=sharing Databases sheet, Databases and SQL section. I've matched the line numbers to those from your incoming file.

@01zulfi
Copy link
Member Author

01zulfi commented May 13, 2024

@MaoShizhong great, I'll get to it in a while

@01zulfi 01zulfi requested a review from MaoShizhong June 1, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaoShizhong MaoShizhong Awaiting requested review from MaoShizhong

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Content: Databases Involves the Databases course Project Node Revamp Issues/PRs related to the Node Revamp project Status: Do Not Merge This PR should not be merged until further notice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make SQL course path agnostic
2 participants
@01zulfi @MaoShizhong