-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update intermediate HTML CSS/ CSS positioning lesson/Additional resources section: Adding a video #27868
Update intermediate HTML CSS/ CSS positioning lesson/Additional resources section: Adding a video #27868
Conversation
…agon,' enriching learning experience with visual demonstrations in the additional resource section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Finn245
Could you resolve the merge conflict please? While doing this, could you also extend the link text for your added video to include"CSS positioning from"? So the link text should read "CSS positioning from Slaying the Dragon". That would make it sufficiently descriptive and accessible.
…CSS positioning lesson
This reverts commit f2788a9.
Looks like there's still the merge conflict to resolve. You can either sync your remote fork with upstream on GH, then redo the fetch and merge resolution to origin main, or you can skip the first step by just fetching from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! Just need the below quick change as well as removing the trailing space on line 72, and the extra blank lines at the end of the file.
Our lesson files need to end with only a single blank line, but it looks like there are 3 blank lines instead.
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
Oh okay so i have to remove the trailing space in line 72 and remove the last line which is the 75 so we keep only 1 blank line(74 one)? |
Yep. Either remove the space on line 72 (it's not blank, it's a line with just a space in it), or remove that line altogether (we don't need it anyway). Then files must end with only a single blank line, so delete any extra blank lines at the end of the file. |
…rriculum into update/css-positioning-lesson
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the new resource, it's a nice video on the topic for sure 👍
Thank you for your kind words! I'm thrilled that you found the new resource helpful. I'm looking forward to contributing more and continuing to enhance this project . Your encouragement means a lot, and I'm excited to collaborate further 😊👍. |
Because:
This PR enhances the CSS positioning lesson by integrating insights and examples from the 'Slay the Dragon' video tutorial, which recaps the CSS positioning concepts covered in the lesson with such an easy examples.
This PR:
Additional Information:
This update enriches the learning experience by providing supplemental material that reinforces key concepts covered in the CSS positioning lesson.