Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced HTML and CSS transitions: add additional article #27860

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fadingmorsecode
Copy link
Contributor

@fadingmorsecode fadingmorsecode commented Apr 26, 2024

Because

This PR aims to introduce stacking context in a way that is less intimidating and easier to understand. The additional article is a less formal introduction to stacking context with analogies and examples that may be easily understood by readers. The PR still keeps the MDN article of stacking context but readers will hopefully have a better understanding while reading it.

This PR

  • Adds additional article to stacking context in assignment

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Advanced HTML/CSS Involves the Advanced HTML/CSS course label Apr 26, 2024
@wise-king-sullyman wise-king-sullyman requested review from a team and ManonLef and removed request for a team April 27, 2024 12:25
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @fadingmorsecode.

I like the Josh Comeau article for sure and think it would be a great add to the lesson. I do actually like it more than the currently linked MDN page, though we should still include the MDN page as it's more of a reference than an article explaining concepts. I feel having them both in the assignments would be a little much just for that point.

Could you move the MDN article out of the assignment list and into the additional resources as its own item?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Advanced HTML/CSS Involves the Advanced HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants