Adds a name attribute to Spinner
#3359
Open
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it nicer for validation and use of the `Spinner` object in later functions/classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it nicer for validation and use of the Spinner object in later functions/classes.
Type of changes
Checklist
Description
Simply adds a
nameattribute toSpinnerfor use in later functions/classes. The current one has no mention ofnameoutside of__init__, but a lot of the functions and classes take a spinner name, not a spinner object. I added this because of some of the stuff I did in pypa/hatch#1490. Would have been nice to make it not a throwaway.