Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BuildShareLink: fix typeof check #7148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BuildShareLink: fix typeof check #7148

wants to merge 1 commit into from

Conversation

pjonsson
Copy link
Contributor

What this PR does

The RHS should be a string, so add
quotes on the existing test.

Test me

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@pjonsson
BuildShareLink: fix typeof check
99ab6ee 
The RHS should be a string, so add
quotes on the existing test.
@pjonsson pjonsson mentioned this pull request May 10, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@pjonsson