Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace @ts-ignore with @ts-expect-error #7134

Merged
merged 1 commit into from
May 22, 2024
Merged

Replace @ts-ignore with @ts-expect-error #7134

merged 1 commit into from
May 22, 2024

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented May 4, 2024

What this PR does

This uncovered some ignores that could
be removed.

Test me

Comment only changes.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@pjonsson
Replace @ts-ignore with @ts-expect-error
ef49cfa 
This uncovered some ignores that could
be removed.
@pjonsson pjonsson mentioned this pull request May 21, 2024
Merged
4 tasks
na9da
na9da approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@na9da na9da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjonsson - looks good, thanks for the PR.

@na9da na9da merged commit 5477721 into TerriaJS:main May 22, 2024
6 checks passed
@pjonsson pjonsson deleted the use-ts-expect-error branch May 22, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@na9da na9da na9da approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pjonsson @na9da