Show feature info panel chart error inline #7133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current behaviour is to pop an error message to the user, but when the load function being connected to the react life-cycle methods, it can be called several times. This results in as many pop ups thrown to the user. We could appropriately handle this if we re-write the component as a functional component. However, I think a better solution might be to show the error message inline instead of popping it to the user.
|
Closing, fixed in #7156 as part of another refactor effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
When feature info panel chart loading fails, show an inline error, instead of a popup.
Current behaviour is to pop an error message to the user, but the load function being connected to the react life-cycle methods, can be called several times. This results in as many pop ups to the user. Also if every feature has an error, then user will have to dismiss the errors for each one of them. I think a better solution might be to show the error inline instead of popping it to the user.
eg:
Test me
Compare behaviour in before and after links.
Before:
Test link for main branch.
clicking anywhere on the dataset resulted in the error popup being shown 4-5 times
After:
Test link for this branch.
no error popups are shown.
Checklist
doc/.