Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to css-loader 3.6.0 #7130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented May 2, 2024

What this PR does

There seems to be some cross-dependency
interplay between css-loader, style-loader,
and mini-css-extract-plugin.

Update css-loader by one major version,
which seems to be the most recent version
that works with the current versions
of the other two libraries.

Test me

I believe this is tested by CI, bumping to the next major gave lots of empty scss files and then failed.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

There seems to be some cross-dependency
interplay between css-loader, style-loader,
and mini-css-extract-plugin.

Update css-loader by one major version,
which seems to be the most recent version
that works with the current versions
of the other two libraries.
pjonsson added a commit to pjonsson/TerriaMap that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant