Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign operator #5042

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

brightening-eyes
Copy link
Contributor

@brightening-eyes brightening-eyes commented Sep 19, 2023

this is one of the simplest things in onnx which I thaught to implement on ncnn.
the same is true with softsign and so on.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Merging #5042 (4d41a89) into master (a12a14f) will decrease coverage by 5.21%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #5042       +/-   ##
===========================================
- Coverage   94.72%   89.52%    -5.21%     
===========================================
  Files         764      252      -512     
  Lines      229616    67839   -161777     
===========================================
- Hits       217513    60733   -156780     
+ Misses      12103     7106     -4997     
Files Changed Coverage Δ
src/layer/sign.cpp 100.00% <100.00%> (ø)

... and 676 files with indirect coverage changes

@nihui
Copy link
Member

nihui commented Sep 20, 2023

sign should be placed in unaryop

@brightening-eyes
Copy link
Contributor Author

I'm doing it like onnxruntime.
I suppose its easier to implement and maintain than unaryop. especially when I do not have experience with loongarch stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants