Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added compile_sdk, min_sdk and target_sdk #3617

Open
wants to merge 1 commit into
base: release/4.0
Choose a base branch
from

Conversation

shalva97
Copy link
Contributor

@shalva97 shalva97 commented Nov 9, 2022

Description

Issue tracker

There was 3 different Android SDKs included:
Screenshot 2022-11-09 at 21 52 03

In gradle files, it had different versions per module, so I added it to ext. Now it show only one:
Screenshot 2022-11-09 at 21 53 41

Is there a reason to have SDK versions different for modules? at least for me having it in ext block looks cleaner, also 2 less SDK is loaded by the studio and I think it should be faster

Automatic tests

  • Added test cases

Manual tests

  • Done

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

Copy link

@JeanPaulLucien JeanPaulLucien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this code. You creates new variables for nothing.

Amaze use 3rd party librabries. These libraries have own requirements. Change configs is bad idea, because nobody tested libs with all custom configs.

@shalva97
Copy link
Contributor Author

These libraries have own requirements

Should not we update them? API 28 was released at 2018...

If you look at build.gradle file commits, you will see that their SDKs were never updated, except the root build.gradle.

You creates new variables for nothing.

if there were those variables probably it would be updated long ago. Anyways Im not 100% sure it should be same version accross all modules, but I also want to know why not. For me having less libs showing up in the list pleases my OCD...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants