BlueSky fixes (OpenSky, Performance model, wypt speed, MVP) #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction in the tools and asas directories
… for the traffic cre function.
…culate the limits. When aircraft fly at/near max Mach, the traf.M can be above max Mach due to simulation time step differences, resulting in a Mach limit based on mmo. Even when a reduction of speed is intended based on conflict resolution. This causes the aircraft to get "stuck" at mmo.
…, dependending on input scenario speed (CAS/Mach)
…in each others protected zone. Generally, this behavior is adequately captured by the mvp algorithm, except when one or more ac are at/near their maximum altitude and have no/little room to climb.
…traf.perf.limits function instead of the OpenAP specific limits. Therefore, speed is converted from GS to TAS and the right vertical speed direction is set.
…scarded in aporasas. Another option is to convert the TAS in the MVP back to GS, however, this causes conversion errors that result in loss of separations for aircraft flying (near) max Mach/altitude.
ninyes
changed the title
ProfHoekstra
requested changes
Apr 28, 2022
|
The review request was not intended. However, I can't find any comments specifying "This". |
This referred to the autopilot fixes. It somehow put my reply underneath. |
…ep is discarded in aporasas. Another option is to convert the TAS in the MVP back to GS, however, this causes conversion errors that result in loss of separations for aircraft flying (near) max Mach/altitude." This reverts commit 716e95c.
…nAP) bs.traf.perf.limits function instead of the OpenAP specific limits. Therefore, speed is converted from GS to TAS and the right vertical speed direction is set." This reverts commit ebe4145.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains a couple of minor fixes regarding the OpenSky plugin, performance modeling, and waypoint speed interpretation. Furthermore, some larger changes regarding the MVP algorithm are included.