[Admin][UI] Add error indicators for form tabs and accordions #16263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoResponseMate
added
UX
Bunnyshell Preview Environment deletedAvailable commands:
|
mpysiak
approved these changes
May 16, 2024
src/Sylius/Bundle/AdminBundle/Resources/assets/controllers/CompoundFormErrorsController.js
Outdated
Show resolved
Hide resolved
GSadee
approved these changes
May 17, 2024
Wojdylak
approved these changes
May 17, 2024
|
Thank you, @NoResponseMate 🎉 |
GSadee
added a commit
that referenced
this pull request
May 20, 2024
…oResponseMate, GSadee, jakubtobiasz, Wojdylak, kulczy, Rafikooo, mpysiak) This PR was merged into the 2.0 branch. Discussion ---------- | Q | A |-----------------|----- | Branch? | 2.0 | Bug fix? | no | New feature? |yes | BC breaks? | yes | Deprecations? | no | Related tickets | | License | MIT As our new Bootstrap Admin Panel is already mostly covered and starting to be functional, I would like to merge branch `bootstrap-admin-panel` to `2.0` and continue the work here. <!-- - Bug fixes must be submitted against the 1.12 or 1.13 branches - Features and deprecations must be submitted against the 1.14 branch - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- c046fb7 Use extension instead of changing the existing forms in ProductBundle 38c8be5 minor review fixes 115d4c2 Revoke change of AutocompleteChoiceType to AdminBundle's one 10a2cc5 move ProductType related extensions definitions to dedicated file 165b84c Bring back the transformer from ProductBundle and create a new one for Admin eff1c8f Use ProductAssociationType instead of extension 2310f81 [Admin][DX] Remove autocompleters 480cfca [Admin][Product] Add ProductAttribute autocomplete type 9516ad0 [Admin][DX] Change `AutocompleteChoiceType` suffix to `AutocompleteType` 72411ad [Admin][DX] Add default aliases to autocomplete fields 6e256e6 [Admin][UX] Add more searchable fields to autocompletes e694fbd Merge branch '2.0' into bootstrap-admin-panel 6b26f4a Add the "sylius.live_component" tag and the translation layer 04fc430 Move all components from the "TwigComponent" directory under the "Twig\Component" directory c2f0596 Convert all AsLiveComponent attribute to the custom sylius.live_component tag 8823b74 Bump ux-symfony packages minimal version 32e2cca Update PHPStan ignore rules for Twig components ce811f2 Fix the malformed sylius_admin:country:form component usages 2fd9297 Fix not adding the 'controller.service_arguments' tag to services tagged with sylius.live_component 1e30fb3 Bring back #[AsLiveComponent] attribute to LiveComponent classes 65969a7 Unfinalize all components 7be88ea Rename `TaxonTreeComponent` component to `TreeComponent` 7e52dfa Fix Product's Form component service id e435ebf Rename `ShipComponent` to `ShipFormComponent` ed65c29 Adjust the Zone's form component to the new standard 3d06429 [Behat] Change mink panther to chromedriver bf3a434 Rename sylius_admin:order:history:address to sylius_admin:order:addresshistory 6f3c0d9 [Behat] Disable behat test 73b4a5f Unify index actions 4cc8549 Add show buttons to the homepage 064db37 Improve filter section 5e319d4 Make bolder header d3748e9 Style grid fields templates 4e6f42d Improve grids view 7d37d78 Fix tests 5fd5746 [Admin][Zone] Move FormComponent 8b6d2b1 [Admin][Zone] Move FormComponent (#16256) 32fcf43 [Admin][Product][Inventory] Enable behat tests 08c3e85 [Admin][Taxon] Implements media management 630f9a1 [Admin][Taxon][Image] Enable behat tests e6deeb4 [Behat] Submit live component before submitting the form e3909ab [Behat] Extract waitForFormUpdate function to CrudFormElement 59695b1 [Taxon][Behat] Extract management of image to separate form element. 554da08 [Admin][Taxon] Remove unnecessary code e30e391 [Admin][Taxon] Split media more granularly f42496c [Admin][Taxon] Rename FormImageElement to ImageFormElement 36e06c0 Merge branch '2.0' into bootstrap-admin-panel bb4e9f3 [Admin][UI] Add error indicators for form tabs and accordions 865a481 Review fixes d1ed503 Remove final from the Zone's form component e6bd06a Remove final from the Zone's form component (#16270) cb9ac59 [Admin][UI] Add error indicators for form tabs and accordions (#16263) 27a9529 [Admin][Product] Add view in store button d8e1758 [Admin][Product] Enable and fix tests f7378ae Changes after CR c940afe Merge branch '2.0' into bootstrap-admin-panel a313b14 Fixes after CR 6d6079e minor #16268 [Admin][Product] Add view in store button (mpysiak) 68da42b [Maintenance] Enable non-UI tests in CI 71ff79c [Behat] Add possibility to accepting null as value in response checker f083d82 [Admin][UX] Filter translatable autocomplete results based on current locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spicy.ribs.show.v2.mov