Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Deprecate FormTypeExtensions #16261

Merged
merged 1 commit into from
May 17, 2024
Merged

[Admin] Deprecate FormTypeExtensions #16261

merged 1 commit into from
May 17, 2024

Conversation

TheMilek
Copy link
Member

Q A
Branch? 1.14
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
License MIT

related to #16257 changes

@TheMilek TheMilek requested review from a team as code owners May 15, 2024 10:26
@probot-autolabeler probot-autolabeler bot added Admin AdminBundle related issues and PRs. Maintenance CI configurations, READMEs, releases, etc. labels May 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 15, 2024 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

Rafikooo
Rafikooo reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@Rafikooo Rafikooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other classes were moved as well, for instance:
Sylius\Bundle\CoreBundle\Form\Type\CatalogPromotionScope\ForProductsScopeConfigurationType
These classes should be aliased and a proper upgrade note should exist.

src/Sylius/Bundle/AdminBundle/Form/Extension/CatalogPromotionActionTypeExtension.php Outdated Show resolved Hide resolved
src/Sylius/UPGRADE-1.14.md Outdated Show resolved Hide resolved
NoResponseMate
NoResponseMate previously approved these changes May 15, 2024
View reviewed changes
@TheMilek
Copy link
Member Author

Some other classes were moved as well, for instance: Sylius\Bundle\CoreBundle\Form\Type\CatalogPromotionScope\ForProductsScopeConfigurationType These classes should be aliased and a proper upgrade note should exist.

but this class wasn't moved https://github.com/Sylius/Sylius/blob/bootstrap-admin-panel/src/Sylius/Bundle/CoreBundle/Form/Type/CatalogPromotionScope/ForProductsScopeConfigurationType.php
🤔

@GSadee GSadee merged commit 62c41a7 into Sylius:1.14 May 17, 2024
28 checks passed
@GSadee
Copy link
Member

GSadee commented May 17, 2024

Thanks, Kamil! 🎉

@TheMilek TheMilek deleted the SYL-3521 branch May 17, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rafikooo Rafikooo Rafikooo left review comments

@GSadee GSadee GSadee approved these changes

@mpysiak mpysiak mpysiak approved these changes

@NoResponseMate NoResponseMate NoResponseMate left review comments

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TheMilek @GSadee @NoResponseMate @mpysiak @Rafikooo