Fix background in settings window #722
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, looks like renaming the branch closes the PR. That wasn't intended. |
|
I'm using the Breeze dark theme with KDE and can confirm this change works as intended. |
|
This fixes multiple reported issues... it should be merged ASAP! Seems there's not a lot of activity in this repo anymore. |
|
Quick workaround: launch like this: QT_QUICK_CONTROLS_STYLE=Material cool-retro-term Ugly, but you can read it. This bug is in a few different places. |
|
fwiw, can confirm, this patch solves the problem described on my KDE desktop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #428, fixes #612, fixes #689
Settings window text is unreadable in dark themes because background is white on any theme. This PR fixes the problem. Works with both dark and light themes.
After fix:
