-
-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove useless warnings #2916
base: master
Are you sure you want to change the base?
Remove useless warnings #2916
Conversation
Well, IDK, I guess it makes sense to show this warning for people who don't know what they're doing. But the detection code needs to get fixed as there are a lot of false positives. |
People who don't know what they're doing will probably see these warnings as a sign that they did something wrong, despite the fact that nothings actually going wrong, hence why these are "useless warnings". |
"Changing a Sector's gravitational constant might have unforeseen side-effects: " These warnings are literally worthless. |
The solid matter warning is nothing more than a nuisance, and the gravity warning has probably discouraged at least one person (me) from using the gravity script. |
My opinion has no weight but I'll comment anyway just so this PR seems more lively. I sent this on IRC earlier anyway and it's not like this PR affected me.
Well, here, this PR is lively again, review/merge when 🥺🤣 |
No description provided.