Prevent infinite recursion in rock's grab and ungrab scripts #2907
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the PR is fine; I just set a script like this in order to prevent it from running infinitely: |
|
However this PR does fix the crash. Thank you!!!! |
weluvgoatz
approved these changes
Apr 15, 2024
|
I'd really like to fix the flickering issue as well so that it only flips once. |
|
Not sure if possible since the script seems to run every frame while the rock is being held, rather than just when you first hold it. |
|
I think the solution might be easier than I initially thought. |
tobbi
force-pushed
the
rock-script-infinite-recursion
branch
from
dae4fe1
to
9a06fb3
Compare
Vankata453
approved these changes
May 31, 2024
weluvgoatz
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents #2906 from happening.