Editor: Adding layers from layers widget #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding layers to a sector now makes more sense, since it's done through a "+" button, found after the last layer on the layers widget. Pressing the button shows an object selection, just like in the toolbox widget, only containing the objects, formerly found in the "Sector" category for non-worldmap levels, and "Tilemap" and "Background" for worldmap levels. Pressing an object directly adds it to the sector. To achieve this, most of the `EditorToolboxWidget` code, which managed tile/object selection, was moved to a different class. The resulting `Tilebox` class can also be used for features like tile backpacks in the future. Closes SuperTux#638.
Vankata453
added
involves:editor
type:feature
category:code
category:design
status:needs-review
|
Difficult to review. From my preliminary look, it seems like the code looks good. But let's avoid disasters and test this thoroughly. I like how this reduces complexity in the editor classes. |
|
Maybe add a border around that thing so it isn't too "out of place"? |
MatusGuy
reviewed
Apr 12, 2024
|
Can you rebase this, please? |
MatusGuy
approved these changes
May 2, 2024
tobbi
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding layers to a sector now makes more sense, since it's done through a "+" button, found after the last layer on the layers widget. Pressing the button shows an object selection, just like in the toolbox widget, only containing the objects, formerly found in the "Sector" category for non-worldmap levels, and "Tilemap" and "Background" for worldmap levels. Pressing an object directly adds it to the sector.
To achieve this, most of the
EditorToolboxWidgetcode, which managed tile/object selection, was moved to a different class. The resultingEditorTileboxclass can also be used for features like tile backpacks in the future.Additionally, this PR allows objects to be moved around right after the editor is started (without an objectgroup having to be active).
Closes #638.