Fix some fallblock issues #2849
Open
+15
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you have any ideas/suggestions of what to use for a fallblock graphic I can work on one. I know that I am using this object for ruin themed levels where some bricks of the ceiling may fall down, so one graphic I will be doing is a cracked/broken version of the ruin brick |
mrkubax10
added
category:code
status:needs-review
|
I decided that the graphics for fallblock can be decided later. This is solely for bug fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There existed an issue where the fallblock would not properly convey that it was going to fall, and I fixed that in this PR. Also, enemies are properly squished by fallblocks.
NOTE: This PR removes the feature where bumpers would cling to fallblocks. This is because the feature is re-added in a more consistent way in PR #2846.
NOTE 2: I think the fallblock needs a new, unique graphic. Maybe when it is drawn it can be added to this PR.