Small cosmetic wind adjustments #2834
Conversation
src/object/sprite_particle.hpp
Outdated
| @@ -39,6 +39,8 @@ class SpriteParticle final : public GameObject | |||
| int drawing_layer = LAYER_OBJECTS-1, bool notimeout = false, Color color = Color::WHITE); | |||
| ~SpriteParticle() override; | |||
|
|
|||
| SpritePtr& get_sprite() { return sprite; } | |||
There was a problem hiding this comment.
Why is this a SpritePtr reference?
There was a problem hiding this comment.
You can make this const if you return SpritePtr (which is std::unique_ptr<Sprite>) instead of SpritePtr&. It doesn't change anything.
There was a problem hiding this comment.
Maybe Sprite& get_sprite() { return *sprite; } would be better?
There was a problem hiding this comment.
You can make this const if you return
SpritePtr(which isstd::unique_ptr<Sprite>) instead ofSpritePtr&. It doesn't change anything.
Doing it this way creates many errors.
There was a problem hiding this comment.
"creates many errors"...WHAT errors?
There was a problem hiding this comment.
It's a unique_ptr, so copy issues I'd assume.
There was a problem hiding this comment.
Many copies of this:
"error C2280: 'std::unique_ptr<Sprite,std::default_delete>::unique_ptr(const std::unique_ptr<Sprite,std::default_delete> &)': attempting to reference a deleted function"
There was a problem hiding this comment.
Or maybe return a SpritePtrinstance by using std::unique_ptr::get()
mrkubax10
added
type:patch
involves:functionality
category:code
status:needs-review
|
This will fail if sprite ever is NULL (null dereference). |
|
@mrkubax10 Were you so certain that sprite could never be null that you deref'ed it without checking? |
|
If you return a pointer instead it will fail in other place. |
|
Not when there's suitable null checks. |
This PR makes the wind particles point in the proper direction now, as well as putting wind on a layer behind others so that you can actually grab other objects in the editor when there's wind in the level.