Move default spawnpoint and sector name ("main") into static variables #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatusGuy
approved these changes
Mar 3, 2024
My code never breaks. |
|
"my code never breaks" Remember the "prevent drawing offscreen" pr? |
The rest of the game wasn't written well enough to support my incredible ideas. |
|
But it broke the game!! Therefore it broke!! |
|
I thought the game would adapt to my code style and just "not break" because it was convinced by the incredible quality of my code. |
|
You stupid |
mrkubax10
reviewed
Mar 4, 2024
mrkubax10
added
type:patch
category:code
status:needs-review
tobbi
force-pushed
the
make_default_spawnpoint_sector_global
branch
from
42634ab
to
41761b0
Compare
|
Have you playtested these changes? |
|
It is literally just a code change. |
|
Ok but have you at least ran the game and the title screen showed up correctly? |
MatusGuy
reviewed
May 1, 2024
Vankata453
reviewed
May 1, 2024
MatusGuy
approved these changes
May 1, 2024
mrkubax10
approved these changes
May 23, 2024
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding "main" for both, I moved it to a variable.
I don't know if this is the right place, though.