Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some Tux animation glitches #2810

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Brockengespenst
Copy link
Contributor

@Brockengespenst Brockengespenst commented Feb 29, 2024

  • Wait until the growing animation is finished before changing to stone animation when smallTux gains an earth flower.
  • Fix animation glitch from sliding to slidegrow
  • Remain in crawling action when down is held and Tux stops sliding due to friction

Fixes #2533

@Brockengespenst
Copy link
Contributor Author

I tried as best as possible to workaround this. Even though this might occur only very rare, it is worth having a look at it. The growing animation is now finished before turning to stone. Transition from growing to stone is not that smooth, to be honest.

Beside this, I noticed some animation glitches when small Tux slides and gains a grow powerup (the hight was adjusted for a small time which led Tux "fly" for a short time), which should be fixed as well.

I did several tests, but someone else (@Rusty-Box ?) should definitely do this as well and provide feedback.

src/object/player.cpp Outdated Show resolved Hide resolved
@mrkubax10 mrkubax10 requested a review from tobbi March 2, 2024 10:05
Copy link
Member

@tobbi tobbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test this, but code looks good.

@mrkubax10 mrkubax10 requested a review from Rusty-Box March 4, 2024 20:38
@mrkubax10 mrkubax10 added status:in-progress Progress has been done, but more is intended be done category:code type:bugfix Pull Requests that fix bugs. labels Mar 4, 2024
@Brockengespenst Brockengespenst marked this pull request as ready for review March 19, 2024 18:40
@Brockengespenst
Copy link
Contributor Author

Looks like recent changes on master broke some of this. I need to rework this.

* Wait until the growing animation is finished before changing to stone
animation when smallTux gains an earth flower.
* Fix animation glitch from sliding to slidegrow
@Brockengespenst Brockengespenst force-pushed the earth_flower_growing_animation branch from f1124c5 to 347c545 Compare May 4, 2024 14:49
@Brockengespenst Brockengespenst changed the title Finish growing animation before turn to stone Fix some Tux animation glitches May 6, 2024
@Brockengespenst Brockengespenst marked this pull request as ready for review May 6, 2024 16:10
@Brockengespenst
Copy link
Contributor Author

Brockengespenst commented May 6, 2024

Ok, next try. Mentionend points in description should be included now.
@weluvgoatz : Would be great if you could check that I did not reintroduce #2838.

@weluvgoatz weluvgoatz added this to the 0.7.0 milestone Jun 1, 2024
@weluvgoatz weluvgoatz self-requested a review June 1, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:code status:in-progress Progress has been done, but more is intended be done type:bugfix Pull Requests that fix bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Earth Tux Animation Bug
4 participants