Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework adding layers to sector #638

Closed
tobbi opened this issue Oct 20, 2016 · 0 comments · Fixed by #2884
Closed

Rework adding layers to sector #638

tobbi opened this issue Oct 20, 2016 · 0 comments · Fixed by #2884

Comments

@tobbi
Copy link
Member

tobbi commented Oct 20, 2016

Having layers and backgrounds / particles in the object menu might not be a good idea. I think they should stay close to the original layer selector, e.g. by having a plus button next to it.

Upon clicking the plus button the user can choose particles, tilemaps, backgrounds and everything else that doesn't technically belong to the "object" side of levels.

@Vankata453 Vankata453 self-assigned this Apr 2, 2024
Vankata453 added a commit to Vankata453/supertux that referenced this issue Apr 2, 2024
Adding layers to a sector now makes more sense, since it's done through a "+" button, found after the last layer on the layers widget. Pressing the button shows an object selection, just like in the toolbox widget, only containing the objects, formerly found in the "Sector" category for non-worldmap levels, and "Tilemap" and "Background" for worldmap levels. Pressing an object directly adds it to the sector.

To achieve this, most of the `EditorToolboxWidget` code, which managed tile/object selection, was moved to a different class. The resulting `Tilebox` class can also be used for features like tile backpacks in the future.

Closes SuperTux#638.
Vankata453 added a commit that referenced this issue May 30, 2024
Adding layers to a sector now makes more sense, since it's done through a "+" button, found after the last layer on the layers widget. Pressing the button shows an object selection, just like in the toolbox widget, only containing the objects, formerly found in the "Sector" category for non-worldmap levels, and "Tilemap" and "Background" for worldmap levels. Pressing an object directly adds it to the sector.

To achieve this, most of the `EditorToolboxWidget` code, which managed tile/object selection, was moved to a different class. The resulting `EditorTilebox` class can also be used for features like tile backpacks in the future.

Additionally, this PR allows objects to be moved around right after the editor is started (without an objectgroup having to be active).

Closes #638.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants