Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Solarman Smart Meter DTSD422-D3 and signed magnitude integer values. #564

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Triple-S
Copy link

Hello,

This commit adds support for Solarman Smart Meter DTSD422-D3. Since this device uses signed magnitude integer values I also had to add a parser for them.

I tested everything with my Home Assistant ant it seemed to work perfectly fine. For the moment I added all values besides the integrated energy values because the binary output shows a lot of values I cannot allocate to any meaningful information which is why I ommited them to not add some wrong information.

This PR fixes #451 and #520.

IMPORTANT QUESTION: I realized that the original signed integer parser is written for one's complement signed integers which I find astonishing since usually two's complement signed integers are used. Was this confirmed that Solarman devices actually use one's complement signed integers? Otherwise all negative values have an offset of -1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solarman DTSD422-D3 Meter Logger
1 participant