Use the is_scaled attribute inside of template_tools functions
#2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes and maybe some other places like computing SNR or sparsity. #2842 was merged too quickly for my taste, I did not read it! |
…terface into fix-template-tools
|
Added sparsity. Checked SNR and it only accepts SortingAnalyzer for now. |
|
merci beaucoup. |
alejoe91
approved these changes
May 15, 2024
samuelgarcia
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #2842 adds an attribute which indicates that the Templates object is scaled we should use that for the functions inside of template_tools no? If the Templates aren't scaled then we can't return scaled.