Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing read_spikeglx_event() #2442

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Implementing read_spikeglx_event() #2442

wants to merge 4 commits into from

Conversation

manimoh
Copy link

@manimoh manimoh commented Jan 29, 2024

No description provided.

@manimoh manimoh mentioned this pull request Jan 29, 2024
Open
@alejoe91 alejoe91 added the extractors Related to extractors module label Jan 29, 2024
@samuelgarcia
Copy link
Member

Hi.
Thanks for this.
This PR is a bit strange because at the momement spikeglx do not handle event in neo.
See this line https://github.com/NeuralEnsemble/python-neo/blob/master/neo/rawio/spikeglxrawio.py#L178

Do you plan to handle events on neo side ?
DO you know how spikeglx handle events ?

@manimoh
Copy link
Author

manimoh commented Mar 23, 2024

Hi @samuelgarcia
Sorry for the late reply!
I did start a PR on the neo repo to implement handling of events. So once that is merged, I guess this can be merged too?

@zm711
Copy link
Collaborator

zm711 commented Apr 29, 2024

Fixes #2242.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
extractors Related to extractors module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@manimoh @samuelgarcia @zm711 @alejoe91