-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add distance / dot product function for comparing spike train similarity #2192
Open
h-mayorquin
wants to merge
13
commits into
SpikeInterface:main
Choose a base branch
from
h-mayorquin:add_distance_function
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add distance / dot product function for comparing spike train similarity #2192
h-mayorquin
wants to merge
13
commits into
SpikeInterface:main
from
h-mayorquin:add_distance_function
+441
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zm711
reviewed
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple docstring/assert comments while you're working on the draft.
Co-authored-by: Zach McKenzie <92116279+zm711@users.noreply.github.com>
@h-mayorquin I'm taking another look at this and it seems in good shape. Maybe we should add an option to the compare_* function to select the matching strategy? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, after this weekend and yesterday and today of frustrations I decided to implement this. This needs some testing so I will put in draft.
Here is the property that I mentioned to you that you can compare to the agreement scores.
The agreement scores are:
1 / ((distance^2 / dot_product) + 1)
As you can see in this graph for the sortngs that @alejoe91 shared with me:
So on the left is the agreement scores calculated with the current formula on main, on the right there is the agrement scores calculate with the distance metric function from the PR.
They are not exactly the same. The distance metric penalizes non-matching burstings but as that is a corner case the overall structure is the same.
[EDIT 1]
I profiled the function against the
make_agreement_scores
in main at this point in time 2023 / 11 / 14:Now I compared two sortings 10 hours long with 1000 units each. It takes the function around 3 minutes in this case.
These are the results:
Gist:
https://gist.github.com/h-mayorquin/ecc2db36e768b8caf3a3f890b20611ff