-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some developer coding notes #85
base: development
Are you sure you want to change the base?
Add some developer coding notes #85
Conversation
Copied from https://github.com/SpeciesFileGroup/taxonworks_doc/blob/40aef883d5d29ece2e736891fea3ef79fbbc6670/development/SCAFFOLDING.md - I made some minor edits, but no "code" changes.
The |
Ah, looks like controller spec generation was removed in rails 5, cf. https://stackoverflow.com/a/66344093 Do we still want to include a controller spec with new models (might require creating one from scratch or copying an existing one), or switch to a request spec as recommended/generated, or something else? |
Controller specs are indeed minimally useful (that's why they were removed by default). IIRC we were copying existing specs. The existing pattern used in other models does re-inforce gatting some things setup ( |
When I did this the first time I started off wanting to add search to the shared show view and remember feeling like there were a lot of separated pieces that I had to track down one by one and figure out, so I added some more detail here.
I added some more content from https://github.com/SpeciesFileGroup/taxonworks_doc/blob/40aef883d5d29ece2e736891fea3ef79fbbc6670/development/HOW-TO.md and added a section on radial annotators and navigators, see if it seems useful (and accurate...). I didn't include the sections with which I have no experience. As always, please feel free to edit or remove anything I've written, or ask me to, I'd be glad to. |
…erate I'm not sure using these commands would be any faster than doing it by hand at this point, probably need a better solution.
It was illustrative to me on several points, but is probably more technical than what these notes are intended for.
So far I've only personally worked through the instructions up through the Model section.