3833 improves COLDP sic handling

[gdower]

Added clean_sic() processing on original combinations and modified the regex to eliminate the space because it was missing name components that included only [sic] with no space. Fixes #3833

[codecov-commenter]

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (b9ee3cd) 84.77% compared to head (e7b60e5) 84.78%.
Report is 11 commits behind head on development.

❗ Current head e7b60e5 differs from pull request most recent head 224e36e. Consider uploading reports for the commit 224e36e to get more accurate results

Files	Patch %	Lines
lib/export/coldp/files/name.rb	21.73%	18 Missing ⚠️
app/controllers/tasks/dwc/dashboard_controller.rb	0.00%	5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##           development    #3835   +/-   ##
============================================
  Coverage        84.77%   84.78%           
============================================
  Files             2100     2100           
  Lines            77526    77509   -17     
============================================
- Hits             65722    65714    -8     
+ Misses           11804    11795    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mjy]

@gdower perhaps you should check once against cached and create a hash of values that you can use to populate here rather than 4 checks?

[gdower]

@mjy, I pushed the branch which improves performance and probably fixes the #3833 and #3834 but I want to test it more before it gets merged.

[mjy]

@gdower what's the status on this one? Should we merge it? Seems there is a current conflict too.

[gdower]

Covered by another PR: #3957