Add wrapper for gbm_device_get_format_modifier_plane_count
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure what to do about the error type here. `gbm_dri_get_format_modifier_plane_count` does potentially return -1, but doesn't set `errno`. Error handling generally looks like it could use some fixes in both gbm.rs and in Mesa...
|
I found myself needing this as well. What's left to be done here? |
Maybe just put this into an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what to do about the error type here.
gbm_dri_get_format_modifier_plane_countdoes potentially return -1, but doesn't seterrno.Error handling generally looks like it could use some fixes in both gbm.rs and in Mesa...