output: pending_xdg is written but never read #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxVerevkin
changed the title
MaxVerevkin
force-pushed
the
remove-pending-xdg
branch
from
77322f2
to
355e6f7
Compare
i509VCB
reviewed
Jan 17, 2023
| @@ -495,16 +487,6 @@ where | |||
| inner.current_info = Some(info.clone()); | |||
| inner.pending_wl = false; | |||
|
|
|||
| if inner | |||
There was a problem hiding this comment.
I believe this will still be needed for version 3 of xdg-output. Although our current interpretation of xdg-output might be wrong.
xdg_output::done states the following:
This event is sent after all other properties of an xdg_output have been sent.
Now this doesn't talk about the properties of wl_output AND xdg_output, but only xdg_output. Don't worry about the technical issue I mentioned, that probably needs to be addressed elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.